✨ Add support for disjunctions in regexes #3927
Merged
+87
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting regex patterns such as `a|b|c` is key if we want to release `stringMatching` at some point. Adding such support is the aim of this PR.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f3f46e:
|
Codecov Report
@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
+ Coverage 94.78% 94.79% +0.01%
==========================================
Files 208 208
Lines 5671 5685 +14
Branches 1270 1274 +4
==========================================
+ Hits 5375 5389 +14
Misses 279 279
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting regex patterns such as
a|b|cis key if we want to releasestringMatchingat some point. Adding such support is the aim of this PR.Category:
Potential impacts: