Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support generation of strings not constrained by ^ or $ #3935

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 30, 2023

Up-to-now generating strings out of regexes not defining ^ and $ was equivalent to having them. It now differs!

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

dubzzz added 3 commits May 30, 2023 12:46
Up-to-now generating strings out of regexes not defining ^ and $ was equivalent to having them. It now differs!
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f1a97e:

Sandbox Source
Vanilla Configuration

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3935 (8f1a97e) into main (4da73fd) will decrease coverage by 0.10%.
The diff coverage is 88.11%.

@@            Coverage Diff             @@
##             main    #3935      +/-   ##
==========================================
- Coverage   94.75%   94.66%   -0.10%     
==========================================
  Files         208      209       +1     
  Lines        5736     5825      +89     
  Branches     1296     1333      +37     
==========================================
+ Hits         5435     5514      +79     
- Misses        284      294      +10     
  Partials       17       17              
Flag Coverage Δ
unit-tests 94.66% <88.11%> (-0.10%) ⬇️
unit-tests-14.x-Linux 94.66% <88.11%> (-0.10%) ⬇️
unit-tests-16.x-Linux 94.66% <88.11%> (-0.10%) ⬇️
unit-tests-18.x-Linux 94.66% <88.11%> (-0.10%) ⬇️
unit-tests-latest-Linux 94.66% <88.11%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/arbitrary/_internals/helpers/SanitizeRegexAst.ts 80.95% <80.95%> (ø)
...heck/src/arbitrary/_internals/helpers/ReadRegex.ts 91.60% <100.00%> (+1.13%) ⬆️
.../src/arbitrary/_internals/helpers/TokenizeRegex.ts 94.38% <100.00%> (+0.23%) ⬆️
...ackages/fast-check/src/arbitrary/stringMatching.ts 82.65% <100.00%> (+2.24%) ⬆️

@dubzzz dubzzz merged commit 8c490a5 into main May 30, 2023
@dubzzz dubzzz deleted the not-start branch May 30, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant