Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Test against more regexes in stringMatching #3936

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 30, 2023

The set of regexes we run stringMatching against was too restricted. In order to cover even more cases, we added some examples extracted from real world.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

The set of regexes we run `stringMatching` against was too restricted. In order to cover even more cases, we added some examples extracted from real world.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ae1df2:

Sandbox Source
Vanilla Configuration

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3936 (3ae1df2) into main (4da73fd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3936      +/-   ##
==========================================
+ Coverage   94.75%   94.82%   +0.07%     
==========================================
  Files         208      208              
  Lines        5736     5761      +25     
  Branches     1296     1308      +12     
==========================================
+ Hits         5435     5463      +28     
+ Misses        284      281       -3     
  Partials       17       17              
Flag Coverage Δ
unit-tests 94.82% <100.00%> (+0.07%) ⬆️
unit-tests-14.x-Linux ?
unit-tests-16.x-Linux ?
unit-tests-18.x-Linux 94.82% <100.00%> (+0.07%) ⬆️
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heck/src/arbitrary/_internals/helpers/ReadRegex.ts 92.30% <100.00%> (+1.83%) ⬆️
.../src/arbitrary/_internals/helpers/TokenizeRegex.ts 94.38% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

@dubzzz dubzzz merged commit d0cc059 into main May 30, 2023
@dubzzz dubzzz deleted the add-more-tests branch May 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant