✨ Support unicode regexes #3939
Merged
+68
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regexes could be flagged as unicode ones by adding a small 'u' on them. When defined that way their behaviour defer a bit on some behaviours. The most important change being that regexes start reading not byte by byte but code point by code point. We just add support for them.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5c1886:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ${/🐱+/u} | ||
| ${/[🐱🐴]/u} | ||
| ${/[🐱-🐴]/u} | ||
| ${/[a-🐱b-🐴]/u} |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regexes could be flagged as unicode ones by adding a small 'u' on them. When defined that way their behaviour defer a bit on some behaviours.
The most important change being that regexes start reading not byte by byte but code point by code point.
We just add support for them.
Category:
Potential impacts: