⚡️ Drop some unneeded allocs in ulid
#4088
Merged
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `ulid` was relying on many unneeded intermediate arrays to construct and deconstruct ulids. We just make it faster by relying on less intermediate arrays. The change should reduce the memory footprint of ulids. More to come with a partial revamp of some parts of the logic.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a80a455:
|
Codecov Report
@@ Coverage Diff @@
## main #4088 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 211 211
Lines 5898 5905 +7
Branches 1353 1351 -2
=======================================
+ Hits 5582 5589 +7
Misses 300 300
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ulidwas relying on many unneeded intermediate arrays to construct and deconstruct ulids. We just make it faster by relying on less intermediate arrays.The change should reduce the memory footprint of ulids.
More to come with a partial revamp of some parts of the logic.
Category:
Potential impacts: