Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stop unwrapping ulid we cannot build #4094

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 19, 2023

Being able to unwrap and deconstruct data that could never be created by one arbitrary can lead to wrong shrinker from being selected and thus strange issues (edge cases but let's avoid them).

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

dubzzz added 2 commits July 19, 2023 17:44
Being able to unwrap and deconstruct data that could never be created by one arbitrary can lead to wrong shrinker from being selected and thus strange issues (edge cases but let's avoid them).
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03fa7ab:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) July 19, 2023 17:51
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4094 (03fa7ab) into main (096685c) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##             main    #4094   +/-   ##
=======================================
  Coverage   94.64%   94.65%           
=======================================
  Files         211      211           
  Lines        5905     5909    +4     
  Branches     1351     1351           
=======================================
+ Hits         5589     5593    +4     
  Misses        300      300           
  Partials       16       16           
Flag Coverage Δ
unit-tests 94.65% <90.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 94.65% <90.00%> (?)
unit-tests-latest-Linux 94.65% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arbitrary/_internals/mappers/UintToBase32String.ts 94.73% <90.00%> (+0.61%) ⬆️

@dubzzz dubzzz merged commit 8f487d8 into main Jul 19, 2023
@dubzzz dubzzz deleted the uld-no-deconstruct-invalid branch July 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant