Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support excluded min/max in double #4100

Merged
merged 8 commits into from
Jul 24, 2023
Merged

✨ Support excluded min/max in double #4100

merged 8 commits into from
Jul 24, 2023

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 20, 2023

Up-to-now, it was not possible to ask for double between min and max with either min or max or both not in the range.

Following the request #4046, we thought about it and started to offer ways to do so.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

dubzzz added 2 commits July 20, 2023 21:21
Up-to-now, it was not possible to ask for double between min and max with either min or max or both not in the range.

Following the request #4046, we thought about it and started to offer ways to do so.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a9770f:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #4100 (1a9770f) into main (983cf86) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4100   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         211      211           
  Lines        5909     5913    +4     
  Branches     1350     1354    +4     
=======================================
+ Hits         5593     5597    +4     
  Misses        300      300           
  Partials       16       16           
Flag Coverage Δ
unit-tests 94.65% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 94.65% <100.00%> (+<0.01%) ⬆️
unit-tests-16.x-Linux 94.65% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x-Linux ?
unit-tests-latest-Linux 94.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/fast-check/src/arbitrary/double.ts 100.00% <100.00%> (ø)

@dubzzz dubzzz enabled auto-merge (squash) July 24, 2023 19:50
@dubzzz dubzzz merged commit 19d9cbc into main Jul 24, 2023
@dubzzz dubzzz deleted the excluded-double branch July 24, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant