-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support excluded min/max in double
#4100
Merged
Merged
+142
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up-to-now, it was not possible to ask for double between min and max with either min or max or both not in the range. Following the request #4046, we thought about it and started to offer ways to do so.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a9770f:
|
dubzzz
commented
Jul 20, 2023
dubzzz
commented
Jul 20, 2023
packages/fast-check/test/unit/arbitrary/__test-helpers__/FloatingPointHelpers.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #4100 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 211 211
Lines 5909 5913 +4
Branches 1350 1354 +4
=======================================
+ Hits 5593 5597 +4
Misses 300 300
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up-to-now, it was not possible to ask for double between min and max with either min or max or both not in the range.
Following the request #4046, we thought about it and started to offer ways to do so.
Category:
Potential impacts: