Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support null-proto in record #4205

Merged
merged 8 commits into from
Sep 6, 2023
Merged

✨ Support null-proto in record #4205

merged 8 commits into from
Sep 6, 2023

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Sep 5, 2023

For now, users will have to explicitly ask for it. But in the next major, the null-prototype will be the default.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
For now, users will have to explicitely ask for it. But in the next major, the null-prototype will be the default.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4dac2e5:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) September 6, 2023 20:40
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4205 (4dac2e5) into main (8527ae6) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4205      +/-   ##
==========================================
+ Coverage   94.68%   94.71%   +0.02%     
==========================================
  Files         211      210       -1     
  Lines        5947     5958      +11     
  Branches     1365     1370       +5     
==========================================
+ Hits         5631     5643      +12     
+ Misses        300      299       -1     
  Partials       16       16              
Flag Coverage Δ
unit-tests 94.71% <100.00%> (+0.02%) ⬆️
unit-tests-16.x-Linux ?
unit-tests-18.x-Linux ?
unit-tests-latest-Linux 94.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nternals/builders/PartialRecordArbitraryBuilder.ts 100.00% <100.00%> (ø)
...internals/mappers/ValuesAndSeparateKeysToObject.ts 97.56% <100.00%> (+0.19%) ⬆️
packages/fast-check/src/arbitrary/record.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@dubzzz dubzzz merged commit ff49d3c into main Sep 6, 2023
@dubzzz dubzzz deleted the null-proto-record branch September 6, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant