Skip to content

💚 Add missing but directly called dependencies #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 24, 2023

When passing Yarn in PnP mode, we got reported several issues in the way we were declaring some dependencies. More preciselly we supposed they were there while we never explicitely pulled them for the project.

This PR makes sure we don't miss any and always explicitely declare them. It will reduce the amount of changes needed for the PnP switch.

Satellite PR for #4368

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
When passing Yarn in PnP mode, we got reported several issues in the way we were declaring some dependencies. More preciselly we supposed they were there while we never explicitely pulled them for the project.

This PR makes sure we don't miss any and always explicitely declare them. It will reduce the amount of changes needed for the PnP switch.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b588c2b:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) October 24, 2023 07:40
@dubzzz dubzzz changed the title 💚 Add missing directly called dependencies 💚 Add missing but directly called dependencies Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #4380 (b588c2b) into main (342638a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4380   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files         207      207           
  Lines        5013     5013           
  Branches     1368     1368           
=======================================
  Hits         4691     4691           
  Misses        322      322           
Flag Coverage Δ
unit-tests 93.57% <ø> (ø)
unit-tests-16.x-Linux 93.57% <ø> (ø)
unit-tests-18.x-Linux 93.57% <ø> (ø)
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dubzzz dubzzz merged commit 5aafd02 into main Oct 24, 2023
@dubzzz dubzzz deleted the add-missing-deps branch October 24, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant