🐛 Also produce null-prototype at root level of generated object when requested to
#4502
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n requested to Our current implementation of `fc.object` with `withNullPrototype: true` was not producing any null-prototype instances at the root. With that fix, it will now produce some. As the change fixes a slightly minor bug that could cause replays to break (the version including it, would not replay to the same values), it might not be included into a patch but wait for a minor).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 953ea45:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4502 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 207 207
Lines 5013 5013
Branches 1368 1368
=======================================
Hits 4691 4691
Misses 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of
fc.objectwithwithNullPrototype: truewas not producing any null-prototype instances at the root. With that fix, it will now produce some.As the change fixes a slightly minor bug that could cause replays to break (the version including it, would not replay to the same values), it might not be included into a patch but wait for a minor).
Category:
Potential impacts: