⚡️ Optimize image assets on homepage #4730
Merged
+823
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current version of https://fast-check.dev/ is badly performing on https://www.websitecarbon.com/. It got an F for the homagepage but a good grade on others. Most of the problem comes from our numerous images assets: - there are many of them to load - they are not optimized in size The current PR is making sure we optimize them beforehand to deliver an optimized version of our assets.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb742e7:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4730 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 207 207
Lines 5011 5011
Branches 1367 1366 -1
=======================================
Hits 4689 4689
Misses 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dubzzz
commented
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current version of https://fast-check.dev/ is badly performing on https://www.websitecarbon.com/. It got an F for the homagepage but a good grade on others.
Most of the problem comes from our numerous images assets:
The current PR is making sure we optimize them beforehand to deliver an optimized version of our assets.
Category:
Potential impacts: