Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Explicitely import from Vitest #4863

Merged
merged 36 commits into from
Apr 7, 2024
Merged

✅ Explicitely import from Vitest #4863

merged 36 commits into from
Apr 7, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 4, 2024

Let's drop the automatic globals being pushed by Vitest and move towards and explicit import of them!

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

Copy link

codesandbox-ci bot commented Apr 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f2a116:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660e551eb0d0efb426683ec1--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660e589fca68cdb8a7373ff0--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660e5ac02a3958b98b10bdfa--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660e5e60916c325a86f3c72c--dubzzz-fast-check.netlify.app

dubzzz added 3 commits April 4, 2024 18:17
Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660ef27a153a623aae4e5e75--dubzzz-fast-check.netlify.app

@dubzzz
Copy link
Owner Author

dubzzz commented Apr 4, 2024

ℹ️ There is probably an issue with the name of snapshots for long names implying outside of BMP plan characters

ℹ️ Vitest does not seem to support poisoning on Function.prototype.apply during expect

ℹ️ expect.not.toBe with {[cloneMethod]: () => self}

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660f20eb1b2173611753c928--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👋 A preview of the new documentation is available at: http://660f3146047d2d0a10502a7d--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660f9f493aa29759a01e12a9--dubzzz-fast-check.netlify.app

dubzzz added 2 commits April 5, 2024 07:01
Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660fa2c84f0a0453173622dd--dubzzz-fast-check.netlify.app

dubzzz added 2 commits April 5, 2024 07:07
Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660fa46e41e16c5bebf2bc51--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660fa710fa5cb65e26e4da07--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660fa85b8743a7598fc2048b--dubzzz-fast-check.netlify.app

@dubzzz dubzzz changed the title ✅ Switch to vitest for the tests of fast-check ✅ Explicitely import from Vitest Apr 7, 2024
dubzzz added 2 commits April 7, 2024 13:31
@dubzzz dubzzz enabled auto-merge (squash) April 7, 2024 13:41
Copy link
Contributor

github-actions bot commented Apr 7, 2024

👋 A preview of the new documentation is available at: http://6612a4a6bdfc6fbdc7ba0134--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (08079e1) to head (7f2a116).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4863      +/-   ##
==========================================
+ Coverage   93.49%   93.57%   +0.07%     
==========================================
  Files         207      209       +2     
  Lines        5015     5093      +78     
  Branches     1314     1360      +46     
==========================================
+ Hits         4689     4766      +77     
+ Misses        326      300      -26     
- Partials        0       27      +27     
Flag Coverage Δ
unit-tests 93.57% <ø> (+0.07%) ⬆️
unit-tests-18.x-Linux 93.57% <ø> (+0.07%) ⬆️
unit-tests-20.x-Linux 93.57% <ø> (+0.07%) ⬆️
unit-tests-latest-Linux 93.57% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 154e195 into main Apr 7, 2024
53 checks passed
@dubzzz dubzzz deleted the switch-to-vitest branch April 7, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant