-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Move tests to Vitest #4871
✅ Move tests to Vitest #4871
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a58359:
|
👋 A preview of the new documentation is available at: http://6612984cbdfc6fb490ba0273--dubzzz-fast-check.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
==========================================
+ Coverage 93.49% 93.57% +0.07%
==========================================
Files 207 209 +2
Lines 5015 5093 +78
Branches 1314 1360 +46
==========================================
+ Hits 4689 4766 +77
+ Misses 326 300 -26
- Partials 0 27 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👋 A preview of the new documentation is available at: http://66129b5c00c5bfbc9c091bdc--dubzzz-fast-check.netlify.app |
From my first measurements, with the same coverage reporter in place for both Jest and Vitest, Vitest is 33% slower. But I hope to make it faster with some cleaning and no globals mode. |
👋 A preview of the new documentation is available at: http://66129e091f1acab74c039ae1--dubzzz-fast-check.netlify.app |
My target is to be able to make fast-check ES Modules first.
I initially attempted to stick to Jest, but I failed. More precisely having Jest in ES Modules mode required: experimental flags, usage of unstable APIs, using arrow imports instead of normal ones, migrating out of spies and relying on requireActual while I'd need to importActual (aka missing API).
Unfortunately I was not able to reach an acceptable state. he main blocker being the arrow import that would impose to add some linting rule to make sure that all my tests do only arrow imports. The next blocker was rewriting all the spies to move them to mock and spies.
So I got directed to Vitest. I tried and spies were ok, import too.
Category:
Potential impacts: