Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Move to v8 for coverage #4873

Merged
merged 2 commits into from
Apr 7, 2024
Merged

✅ Move to v8 for coverage #4873

merged 2 commits into from
Apr 7, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 7, 2024

Instanbul used to be the default when we relied on Jest. V8 having its own coverage measurements, we are trying to move to it and to see how much it will impact our coverage.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

Copy link

codesandbox-ci bot commented Apr 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77bd004:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Apr 7, 2024

👋 A preview of the new documentation is available at: http://6612a49f4a79d1bb9e4878d1--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (08079e1) to head (77bd004).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4873      +/-   ##
==========================================
+ Coverage   93.49%   96.88%   +3.38%     
==========================================
  Files         207      210       +3     
  Lines        5015    16117   +11102     
  Branches     1314     2620    +1306     
==========================================
+ Hits         4689    15615   +10926     
- Misses        326      502     +176     
Flag Coverage Δ
unit-tests 96.88% <ø> (+3.38%) ⬆️
unit-tests-18.x-Linux 96.88% <ø> (+3.38%) ⬆️
unit-tests-20.x-Linux 96.88% <ø> (+3.38%) ⬆️
unit-tests-latest-Linux 96.88% <ø> (+3.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit b32afae into main Apr 7, 2024
69 checks passed
@dubzzz dubzzz deleted the v8-cov branch April 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant