✅ Better mock/spy cleaning #4875
Merged
+185
−410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e36832e:
|
|
👋 A preview of the new documentation is available at: http://6612ac21a1c26ac30ea2308c--dubzzz-fast-check.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4875 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 210 210
Lines 16117 16117
Branches 2619 2621 +2
=======================================
Hits 15615 15615
Misses 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever running tests playing with mocks or spies, we have to make sure to properly clean everything. But over cleaning is as bad as no cleaning, more precisely, from a CI point of view, over cleaning tend to make tests slower.
This PR introduce a shared helper responsible to clean anything related to spies. It has to be added on case by case basis to clean describe-blocks using spies between every it and after the block, so that other blocks don't get broken by a previously running describe-block.
Category:
Potential impacts: