Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak documentation in Arbitraries.md #523

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Conversation

willheslam
Copy link
Contributor

subarray and shuffledSubarray require both min and max in order to constrain the size of the subarray, not just a single argument.

  if (minLength != null && maxLength != null) return new SubarrayArbitrary(originalArray, false, minLength, maxLength);
  return new SubarrayArbitrary(originalArray, false, 0, originalArray.length);

In a nutshell

✔️ Documentation improvement

subarray and shuffledSubarray require both min and max in order to constrain the size of the subarray, not just a single argument.
```
  if (minLength != null && maxLength != null) return new SubarrayArbitrary(originalArray, false, minLength, maxLength);
  return new SubarrayArbitrary(originalArray, false, 0, originalArray.length);
```
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24d3856:

Sandbox Source
happy-morning-59w4q Configuration
still-fog-54c4l Configuration

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.415% when pulling 24d3856 on willheslam:patch-2 into 6e1e7ef on dubzzz:master.

@dubzzz dubzzz merged commit 93350f2 into dubzzz:master Jan 5, 2020
@dubzzz
Copy link
Owner

dubzzz commented Jan 5, 2020

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants