🐛 Stack overflows while shrinking large arrays of commands #541
+78
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a50a54b:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR for?
Shrink of large arrays of commands was causing crashes of fast-check.
As we did for
arrayandshuffledSubarrayin #505, we fixed the shrinker ofcommandsso that it can be executed on large arrays of commands without running into stack overflows or other crashes.Related to #499
Fixes #508
In a nutshell
❌ New feature
✔️ Fix an issue
❌ Documentation improvement
❌ Other: please explain
(✔️: yes, ❌: no)
Potential impacts
None.
Shrinker keeps shrinking towards the same values. We just tend to limit the stack size required to do it, and limit as much as possible every unneeded computations.