Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support type guards while filtering #555

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 18, 2020

Why is this PR for?

Support type guards while filtering
Fixes #545

In a nutshell

✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

None expecting. We need to confirm it will not break any existing typings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f72cb20:

Sandbox Source
modest-euclid-zhefx Configuration
wild-feather-2rq3j Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Feb 18, 2020

I still need to see what's the best solution to handle https://github.com/dubzzz/fast-check/pull/555/files#diff-e874ec8f9333a86a7d38aaab01e2fa59R79-R81

As of today, it may produce invalid typings when calling filter on a shrinkable. Nonetheless, it should not be a huge issue as it will only occured when passed a refinement with an explicit value is U.

@coveralls
Copy link

coveralls commented Feb 18, 2020

Coverage Status

Coverage increased (+0.005%) to 96.316% when pulling f72cb20 on feat/refinement-filter into 1ceb2b9 on master.

@dubzzz
Copy link
Owner Author

dubzzz commented Feb 27, 2020

Green run in Travis - https://travis-ci.org/dubzzz/fast-check/builds/655993341

@dubzzz dubzzz merged commit 623da12 into master Feb 27, 2020
@dubzzz dubzzz deleted the feat/refinement-filter branch February 27, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support type guards while filtering
2 participants