Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix fc.object() with withNullPrototype #567

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 1, 2020

Why is this PR for?

The code of fc.object() was trying to spread an Arbitrary, which is a totally illegal operation. Transpilation may have covered the bug...

In a nutshell

❌ New feature
βœ”οΈ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(βœ”οΈ: yes, ❌: no)

Potential impacts

None. Fixes a potential bug :)

The code of `fc.object()` was trying to spread an `Arbitrary`, which is a totally illegal operation. Transpilation may have covered the bug...
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c435199:

Sandbox Source
vibrant-feistel-0yowo Configuration
fast-star-t2b8z Configuration

@dubzzz dubzzz merged commit 69d8345 into master Apr 1, 2020
@dubzzz dubzzz deleted the fix/type-error-when-withNullPrototype branch April 1, 2020 20:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.135% when pulling c435199 on fix/type-error-when-withNullPrototype into a8d2ebb on master.

dubzzz added a commit that referenced this pull request Apr 1, 2020
The code of `fc.object()` was trying to spread an `Arbitrary`, which is a totally illegal operation. Transpilation may have covered the bug...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants