Skip to content

✅ Check the package can be properly imported on various configurations #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 25, 2020

Why is this PR for?

Check the package can be properly imported on various configurations.
For the moment, only legacy configurations are enabled, ESM based ones will be activated with the final step that adds full support for ESM (while preserving old support to commonjs).

Step 2 in the migration to ESM.

In a nutshell

❌ New feature
❌ Fix an issue
❌ Documentation improvement
✔️ Other: tests

(✔️: yes, ❌: no)

Potential impacts

None

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e684fe:

Sandbox Source
old-cdn-womq2 Configuration
peaceful-mclean-k8czp Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dubzzz dubzzz force-pushed the test/check-esm-support branch from 3f21f01 to 73cdfd7 Compare April 25, 2020 17:03
@coveralls
Copy link

coveralls commented Apr 25, 2020

Coverage Status

Coverage remained the same at 96.145% when pulling 4e684fe on test/check-esm-support into 2e6ef6c on master.

@dubzzz dubzzz merged commit 368563b into master Apr 25, 2020
@dubzzz dubzzz deleted the test/check-esm-support branch April 25, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants