Skip to content

💚 Check compatibility with node 12.x and >= 12.18 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 3, 2020

Why is this PR for?

Now that node 12 has been unflagged and support ES Modules out-of-the-box, we need to ensure it will work correctly with fast-check.

For holder releases (<12.18) and new ones (>=12.18)

In a nutshell

❌ New feature
❌ Fix an issue
❌ Documentation improvement
✔️ Other: CI for CommonJS and ESM checks

(✔️: yes, ❌: no)

Potential impacts

None

Now that node 12 has been unflagged and support ES Modules out-of-the-box, we need to ensure it will work correctly with fast-check.

For holder releases (<12.18) and new ones (>=12.18)
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1572873:

Sandbox Source
priceless-curran-b2vx4 Configuration
modest-lamarr-10eth Configuration

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.007% when pulling 1572873 on ci/cover-more-variant-for-commonjs-esm into e7b6f50 on master.

@dubzzz dubzzz merged commit 652f154 into master Jun 3, 2020
@dubzzz dubzzz deleted the ci/cover-more-variant-for-commonjs-esm branch June 3, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants