✅ E2E for AsyncScheduler were relying on changing data #630
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See:
```
Received: 1
at propertyValidator (C:\dev\fast-check\test\e2e\AsyncScheduler.spec.ts:152:21)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at AsyncProperty.run (C:\dev\fast-check\src\check\property\AsyncProperty.generic.ts:31:22)
at asyncRunIt (C:\dev\fast-check\src\check\runner\Runner.ts:44:17)
- at Object.<anonymous> (C:\dev\fast-check\test\e2e\AsyncScheduler.spec.ts:155:17)
+ at Object.<anonymous> (C:\dev\fast-check\test\e2e\AsyncScheduler.spec.ts:169:22)
```
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6234167:
|
larrybotha
added a commit
to larrybotha/fast-check
that referenced
this pull request
Jun 16, 2020
* master: ✅ E2E for AsyncScheduler were relying on changing data (dubzzz#630) ⬆️ Bump rollup from 2.15.0 to 2.16.1 (dubzzz#628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR for?
The E2E tests written for
AsyncSchedulerwere relying on changing data. They failed as soon as we updated the targeted versions of node, ts... (see branch next-1_25_1)See:
In a nutshell
❌ New feature
✔️ Fix an issue
❌ Documentation improvement
❌ Other: please explain
(✔️: yes, ❌: no)
Potential impacts
None