✅ Compilation against old releases of TypeScript #661
Merged
+69
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent unwanted breaking changes causing older (and supported) versions of TypeScript not to compile anymore.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit edfd181:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR for?
Prevent unwanted breaking changes causing older and supported versions of TypeScript not to compile anymore.
Introducing a regression in typings that prevents older versions of TypeScript to to compile properly is too easy. For instance a lib exporting one function containing
unknownwill automatically breaks any users that rely on TypeScript < 3.0 even if they do not use this function at all. This commit ensures that such regression would be detected earlier in the development process.Users of fast-check should not be forced to toggle
skipLibCheckto use it. fast-check should compile without this trick.In a nutshell
❌ New feature
❌ Fix an issue
❌ Documentation improvement
✔️ Other: ci - non regression test
(✔️: yes, ❌: no)
Potential impacts
None