Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’₯ Remove support for with_deleted_keys on fc.record #749

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 12, 2020

Merge of PR #570 to master


Why is this PR for?

Remove support for previously depreciated parameter in fc.record.

In a nutshell

❌ New feature
❌ Fix an issue
❌ Documentation improvement
βœ”οΈ Other: remove depreciated feature

(βœ”οΈ: yes, ❌: no)

Potential impacts

Remove depreciated feature.
All references to with_deleted_keys should changed into withDeletedKeys.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2020 β€’

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2f6a07:

Sandbox Source
Vanilla Configuration
dubzzz/fast-check: example Configuration

@dubzzz dubzzz changed the title πŸ’₯ Remove support for with_deleted_keys on fc.record (#570) πŸ’₯ Remove support for with_deleted_keys on fc.record Jul 12, 2020
@coveralls
Copy link

coveralls commented Jul 12, 2020 β€’

Coverage Status

Coverage decreased (-0.07%) to 95.76% when pulling e2f6a07 on delete-keys into 84aa5a7 on master.

@dubzzz dubzzz merged commit ef64456 into master Jul 12, 2020
@dubzzz dubzzz deleted the delete-keys branch July 12, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants