Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(πŸ’₯)✨ Support ES Modules and CommonJS #752

Merged
merged 2 commits into from
Jul 12, 2020
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 12, 2020 β€’

Merge of PR #517 to master

Pre-requisite: #753


Why is this PR for?

Support ES Modules and CommonJS
Related to #478

In a nutshell

βœ”οΈ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(βœ”οΈ: yes, ❌: no)

Potential impacts

On its own this PR is not supposed to introduce any changes for the final users.
But as it might be a pretty dangerous change highly impacting the repo, it might require a major on its own. Just to be safe enough.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2020 β€’

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3818a41:

Sandbox Source
Vanilla Configuration
dubzzz/fast-check: example Configuration

@coveralls
Copy link

coveralls commented Jul 12, 2020 β€’

Coverage Status

Coverage increased (+0.07%) to 95.659% when pulling 3818a41 on support-esm-cjs into 0a2a52d on master.

@dubzzz dubzzz merged commit 9b7f369 into master Jul 12, 2020
@dubzzz dubzzz deleted the support-esm-cjs branch July 12, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants