Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the integration tests in headless Chrome #1157

Merged
merged 1 commit into from May 12, 2022

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented May 7, 2022

Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260

Reviewer: @jonathanKingston

CC: @kdzwinel, @ladamski

Steps to test this PR:

Verify that integration tests are still passing both on CI and locally.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@kzar
Copy link
Collaborator Author

kzar commented May 7, 2022

(See also my suggested changes to the Puppeteer docs: puppeteer/puppeteer#8321.)

Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260
@kzar kzar force-pushed the headless-puppeteer branch 2 times, most recently from 1c74c9d to 197d082 Compare May 12, 2022 11:44
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nice!

@jonathanKingston jonathanKingston merged commit bd583bd into duckduckgo:develop May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants