New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATB parameter in MV3 #1585
ATB parameter in MV3 #1585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enable the ATB integration tests for MV3 too?
d4e2ef5
to
09ac5c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good % a couple of nits. The main thing that concerns me is why we needed to disable some of the integration tests, are you sure the tests are broken and not the feature itself?
Co-authored-by: Dave Vandyke <kzar@kzar.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewer:
Description:
Adds ATB to search URL.
Steps to test this PR:
Reviewer Checklist:
PR Author Checklist: