This repository has been archived by the owner on May 17, 2023. It is now read-only.
Add imageProxyThumbnail to request smaller thumbnails #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsstoner
reviewed
Aug 11, 2019
| */ | ||
|
|
||
| Handlebars.registerHelper("imageProxyThumbnail", function(url) { | ||
| return DDG.getImageProxyURL(url, false, false, 204); |
There was a problem hiding this comment.
Hard coding 204 in here and wrapping it as a generic function seems odd. If it's a generic helper function, it should probably be a variable. And if 204 is hard coded, maybe it should just be a function inside the image IA.
Another approach could be added a second size argument to the regular imageProxy helper? Maybe that would be more reusable?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request smaller thumbnails for images, used in
duckduckgo-answerbar-templates