allow unserialize all classes

[regnerisch]

I had an issue with this: I saved Objects and on getting them back i got __PHP_Incomplete_Class Error. This will fix it.

[codecov]

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage     99.46%   99.46%           
  Complexity       78       78           
=========================================
  Files             6        6           
  Lines           187      187           
=========================================
  Hits            186      186           
  Misses            1        1

Impacted Files	Coverage Δ	Complexity Δ
src/FilesystemPool.php	98.24% <100%> (ø)	23 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0177054...f131295. Read the comment docs.

[duncan3dc]

Hi @Tera3yte, thanks for your contribution but that's not the best fix for your issue, as it opens up a security risk.

Do you have a short script to reproduce the problem you were seeing?

[regnerisch]

$adapter = new \Http\Adapter\Guzzle6\Client();
$provider = new \Geocoder\Provider\GoogleMaps\GoogleMaps($adapter, 'en', 'GOOGLE_MAPS_KEY');
$providerCache = new \Geocoder\Provider\Cache\ProviderCache($provider, new \duncan3dc\Cache\FilesystemPool(__DIR__ . '/cache'));
$geocoder = new \Geocoder\StatefulGeocoder($providerCache, 'en');

$result = $geocoder->geocodeQuery(\Geocoder\Query\GeocodeQuery::create(sprintf('%s %s %s %s %s',
           'address_line_1',
           'address_line_2',
           'postcode',
           'city',
           'country'
        )));

This Code saves .cache-Files as:

O:20:"duncan3dc\Cache\Item":3:{s:25:"\00duncan3dc\Cache\Item\00key";s:42:"v4a2b8c22810b6846a69686ab8ad6f15a772380ab2";s:27:"\00duncan3dc\Cache\Item\00value";O:32:"Geocoder\Model\AddressCollection":1:{s:43:"\00Geocoder\Model\AddressCollection\00locations";a:1:{i:0;O:48:"Geocoder\Provider\GoogleMaps\Model\GoogleAddress":29:{s:52:"\00Geocoder\Provider\GoogleMaps\Model\GoogleAddress\00id";s:103:"SOME_RANDOM_STRING";s:62:"\00Geocoder\Provider\GoogleMaps\Model\GoogleAddress\00locationType";s:7:"ROOFTOP";s:60:"\00Geocoder\Provider\GoogleMaps\Model\GoogleAddress\00resultType";a:1:{i:0;s:10:"subpremise";} [...]

And on trying to get the Cache Item Back the Script fails because of the __PHP_Incomplete_Class. I'm sure this problem will occur on every object-value.

[duncan3dc]

That's great @Tera3yte thanks. It looks like there's no reasonable way around this and the onus has to be on library consumers to ensure they are protected their cache data securely.