Fix database is locked when performing auto cleanup #4971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4631, closes #3635
When a backup with
--auto-cleanup
detects unknown files, a repair is triggered while the database connection is still open. Because repair creates its own database connection, this causes an errorThe process cannot access the file because it is being used by another process
(even though it is the same process).Steps to reproduce error:
--auto-cleanup
On the destination, duplicate a dblock file and change a few digits in the name
Delete the local database of the backup (using UI works)
Backend verification failed, attempting automatic cleanup
Current behavior:
error: database is locked database is locked
in live logThe process cannot access the file because it is being used by another process
New behavior:
Backend verification failed, attempting automatic cleanup
and more warnings about the missing/extra files