Allow setting the content type for multipart uploads #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use case: when uploading a ~1GB gzip-compressed file to a MinIO storage the file upstream ends up with a different SHA-256 hash value if I don't specify the correct content type, even though the file can be extracted normally. Setting the content type to |
|
Hi @durch , any updates on a review for this one? Anything I can do to help? |
|
@ns-sjorgedeaguiar great stuff, took me a while to get to this :) |
|
@durch thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the patch from @chuigda, rebased onto master with
docs extended.
Fixes #172