Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: automatically expand collapse when mouse hovers on the menu bar #138

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

p-z-l
Copy link
Contributor

@p-z-l p-z-l commented May 31, 2021

What's this PR do?

  • Automatically expand or collapse when mouse hovers on the menu bar
  • Stops collapse if the mouse clicked inside the menu bar area before leaving
  • Works with multiple screens

What are the relevant Git tickets?

#115 was a very similar PR also by me but it was closed because the code and commit history is messy and it has merge conflicts with the develop branch.

Any background context you want to provide? (if appropriate)

Behavior:

  1. Expands the menu bar when the mouse is inside the menu bar area
  2. When the mouse leaves menu bar area and did not click on the menu bar, status bar collapses

@viettrungphan
Copy link
Collaborator

We need more test. How it work with new "full menu bar" feature.Did you resolve the problem with checking Menu opening?
I will keep this for the future release. The next release already has many features and bugs fixed, better to release it now.
Btw, we should have better name for this feature, something that easy to understand without explanation.

@p-z-l
Copy link
Contributor Author

p-z-l commented Jun 1, 2021

I'm thinking of identifying a window as menu window by checking if:

  • a window's top edge equals to the status bar bottom edge
  • a window doesn't stick to any edges of the screen
  • a window has kCGWindowLayer > 100 and kCGWindowLayer < 150

Also, I'm not sure what do you mean by full menu bar feature? If you're referring to the always hide feature, I'm not seeing any problem with that.

@validatedev
Copy link

I think the implementation of #182 is going to be easier if this is merged. Thanks for your effort!

@aab203
Copy link

aab203 commented Dec 10, 2021

This is a great feature and something I'm keen to see as I have had to revert to not auto-collapsing given it's not a great UX when the bar auto-collapses after X seconds but you are still using/viewing a menu bar item's dropdown.
@p-z-l Is this likely to be ready for a release soon?
Thanks!

@kevindiu
Copy link

Waiting for this feature release!

@p-z-l
Copy link
Contributor Author

p-z-l commented Feb 12, 2022

Waiting for this feature release!

Sorry guys for the long wait :(, I got a lot of things irl that needs to be sorted out. I will resume work on this right after I got my OS and Xcode updated

@kevindiu
Copy link

kevindiu commented Mar 3, 2022

NP! We didn't pay you anything and we appreciate your time and your work.
Enjoy your life first :)

@GitSparTV
Copy link

Any news? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants