Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tooltip component #1968

Merged
merged 37 commits into from May 8, 2024
Merged

Added Tooltip component #1968

merged 37 commits into from May 8, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Apr 30, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Adding a tooltip component is very important in order to achieve higher consistency, scalability, better interactivity and accessibility.

Screenshots
image

Closes #1964

Mil4n0r and others added 21 commits April 24, 2024 16:55
@Mil4n0r
Started working on the Tooltip component
656933e
@Mil4n0r
Completed tooltip component
7c542d4
@Mil4n0r
Added functional testing for tooltip component
a819a20
@Mil4n0r
Applied new tooltip to existing components
fab2b9f
@Mil4n0r
Changed tooltip implementation
dc6e4a5
@Mil4n0r
Added storybook interaction
0896d09
@Mil4n0r
Removed unneeded code
033177d
@Mil4n0r
Fixed format
1a7ef18
@Mil4n0r
Fixed format
f86a8df
@Mil4n0r
Fixed multi-line tooltips
7706ada
@Mil4n0r
Added improvements to Tooltip based on feedback from DSDR
a4113b8
@Mil4n0r
Merge branch 'master' of github.com:dxc-technology/halstack-react int…
3770541 
…o Mil4n0r/tooltip-component
@Mil4n0r
Fixed old version of storybook test library
74a3e1e
@Mil4n0r
Fixed tooltip tests and swapped prop names
002d5eb
@Mil4n0r
Changed prop name title to label
a44e8eb
@Mil4n0r
Modified max-width for tooltip
057e5a5
@Mil4n0r
Merge branch 'master' into Mil4n0r/tooltip-component
fc0ab3f
@Mil4n0r
Modified spacing in stories
64d3e43
@Mil4n0r
Merge branch 'Mil4n0r/tooltip-component' of github.com:dxc-technology…
73c2198 
…/halstack-react into Mil4n0r/tooltip-component
@Mil4n0r
Added support for table actionicons tooltips
ec5931d
@Mil4n0r
Restored changes outside Tooltip component
ee9a451
@Mil4n0r Mil4n0r marked this pull request as ready for review April 30, 2024 13:13
@Jialecl Jialecl self-requested a review April 30, 2024 14:04
@Jialecl Jialecl self-assigned this Apr 30, 2024
Jialecl
Jialecl reviewed Apr 30, 2024
View reviewed changes
lib/src/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
lib/src/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
lib/src/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
lib/src/tooltip/types.tsx Outdated Show resolved Hide resolved
lib/src/tooltip/Tooltip.stories.tsx Show resolved Hide resolved
Jialecl
Jialecl reviewed May 2, 2024
View reviewed changes
lib/src/tooltip/Tooltip.test.tsx Show resolved Hide resolved
lib/src/tooltip/Tooltip.tsx Show resolved Hide resolved
lib/src/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
lib/src/tooltip/Tooltip.test.tsx Outdated Show resolved Hide resolved
@Mil4n0r Mil4n0r requested a review from Jialecl May 7, 2024 13:29
@Jialecl Jialecl merged commit c2b6ec9 into master May 8, 2024
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/tooltip-component-adaptations branch May 8, 2024 07:17
This was referenced May 8, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the DxcTooltip component to the library
2 participants
@Mil4n0r @Jialecl