Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix Nx caching issue #1935

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

wittjosiah
Copy link
Member

This does actually seem to resolve the caching issue.

There's a closed Nx issue about this nrwl/nx#10442 and a merged PR nrwl/nx#10455, however the PR was later reverted nrwl/nx#10455 (comment) and does not seem to have been fixed again yet as far as I can tell.

I've left a note on the original issue that I think it should be re-opened.

Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #1935 (02cd0f4) into main (0a4f0c7) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   71.69%   71.55%   -0.14%     
==========================================
  Files         454      454              
  Lines       16387    16199     -188     
  Branches     2516     2479      -37     
==========================================
- Hits        11748    11591     -157     
+ Misses       3591     3569      -22     
+ Partials     1048     1039       -9     
Impacted Files Coverage Δ
packages/common/crypto/src/verify.ts 83.33% <0.00%> (-16.67%) ⬇️
packages/core/halo/keyring/src/keyring.ts 65.85% <0.00%> (-11.78%) ⬇️
...s/core/halo/credentials/src/credentials/signing.ts 76.47% <0.00%> (-11.41%) ⬇️
.../core/halo/credentials/src/credentials/verifier.ts 75.86% <0.00%> (-5.39%) ⬇️
...edentials/src/state-machine/space-state-machine.ts 64.28% <0.00%> (-4.87%) ⬇️
...random-access-storage/src/common/memory-storage.ts 92.85% <0.00%> (-3.58%) ⬇️
packages/common/util/src/callback.ts 69.69% <0.00%> (-3.04%) ⬇️
packages/core/mesh/mesh-protocol/src/protocol.ts 71.11% <0.00%> (-0.38%) ⬇️
...ges/core/halo/credentials/src/credentials/index.ts 100.00% <0.00%> (ø)
...redentials/src/state-machine/feed-state-machine.ts 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wittjosiah wittjosiah force-pushed the wittjosiah/11-20-chore_Upgrade_to_latest_Nx branch from 9c13e1e to 8bc5e77 Compare November 21, 2022 12:20
@wittjosiah wittjosiah force-pushed the wittjosiah/11-20-build_Fix_Nx_caching_issue branch from 0782595 to 81b32d1 Compare November 21, 2022 12:20
@wittjosiah wittjosiah force-pushed the wittjosiah/11-20-chore_Upgrade_to_latest_Nx branch from 8bc5e77 to af043c1 Compare November 22, 2022 21:02
@wittjosiah wittjosiah force-pushed the wittjosiah/11-20-build_Fix_Nx_caching_issue branch from 81b32d1 to 02cd0f4 Compare November 22, 2022 21:02
Copy link
Member Author

wittjosiah commented Nov 22, 2022

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: 4bRVZZKcvSuExAfRDRBd

Base automatically changed from wittjosiah/11-20-chore_Upgrade_to_latest_Nx to main November 22, 2022 21:17
@wittjosiah wittjosiah merged commit dfffbfc into main Nov 22, 2022
@wittjosiah wittjosiah deleted the wittjosiah/11-20-build_Fix_Nx_caching_issue branch November 22, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant