Add types to query context on PgError #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynajoe
reviewed
Jun 15, 2023
|
Alright. The issue was something in the Lodash types was unable to resolve in the tests given the test tsconfig. I just set it to strict, fixed the issues, and the lodash compile issue went away. should be good to go if the test changes are approved. |
|
@dynajoe Do you want to merge and release this? |
|
Wanted to follow up here since it's been a little while! Would be fun to have this fix in. |
|
@dynajoe Can you release this change? |
Hi Stephen |
👋 Do you know how to kick off releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40