Align projection tensor calculations with master #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacob-Stevens-Haas
changed the title
Merged
|
Ok I'm going to merge this one now, I need to start digging into the algorithm stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the simplified routines for creating the projection tensors. The simplification is possible because of explicitly relying on the
PolynomialLibrarythrough the helper function_build_lib_info, which allows methods to look up indexes for relevant terms. As a result, the PQ and PL matrices now have tests to ensure they are built correctly.We also remove the
check_P_tensorsfunction, because we have explicit tests.Finally, this also
For review, start with the tests, then the projection calculations. If desired, see the helper functions.