Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue where bazel could not create runfiles on windows. #1579

Merged
merged 1 commit into from Sep 25, 2020
Merged

Fixes an issue where bazel could not create runfiles on windows. #1579

merged 1 commit into from Sep 25, 2020

Conversation

lukasholzer
Copy link
Contributor

@lukasholzer lukasholzer commented Sep 8, 2020 •
edited

This issue is due to some legacy run files linking where a manifest file was expected where it was not on windows.
It constantly failed with:

ERROR: Manifest file c:\Users\ADMINI~1\_BAZEL~1\rgyky3dz\execroot\EXAMPL~1\bazel-out\x64_windows-fastbuild\bin\test.bat.runfiles\examples_jest\test.bat.runfiles_manifest does not exist.

Issue described here: bazelbuild/rules_nodejs#1454

The only thing that might be needed under windows is a .bazelrc.user where the output path is set as there might be some issues with the max path length on windows.
https://docs.bazel.build/versions/3.5.0/windows.html#avoid-long-path-issues

startup --output_user_root=C:/tmp

Pull Request

Hi, thank you for contributing to Barista with this pull request (PR).

To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.

  • A feature proposal has been provided, discussed and approved first.
  • There is a meaningful description of the issue in GitHub (Screenshots are
    often helpful).
  • If the PR introduces breaking-changes or deprecations it matches the following
    guidelines.
    • The commit message follows our commit guidelines.
    • Tests for the changes have been added (for bug fixes / features).
    • Docs have been added / updated (for bug fixes / features).

Please choose the type appropriate for the changes below:

Type of PR

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@lukasholzer lukasholzer added the bazel All issues realted to bazel build system label Sep 8, 2020
@lukasholzer lukasholzer marked this pull request as draft September 8, 2020 13:58
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

Deploy preview for barista ready!

Built with commit 93fdbe0

✅ Preview: https://barista-hf4cx1mzf.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer
Copy link
Contributor Author

@SkaillZ fixed it for the rules_nodejs as well ;) bazelbuild/rules_nodejs#2178

@lukasholzer lukasholzer marked this pull request as ready for review September 8, 2020 14:11
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

Deploy preview for barista ready!

Built with commit 0917825

✅ Preview: https://barista-mm7crqpnd.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer marked this pull request as draft September 9, 2020 06:44
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Deploy preview for barista ready!

Built with commit 3a82ac6

✅ Preview: https://barista-9pv3b26lt.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Deploy preview for barista ready!

Built with commit c0d0483

✅ Preview: https://barista-7ghtpm6s5.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer
Copy link
Contributor Author

patch file has to be in there until stylelint/stylelint#4929 and sindresorhus/globby#152 are resolved for stylelint on windows.

@lukasholzer lukasholzer marked this pull request as ready for review September 9, 2020 11:21
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Deploy preview for barista ready!

Built with commit a034f9b

✅ Preview: https://barista-on38y53bb.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer marked this pull request as draft September 10, 2020 08:28
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit af46054

✅ Preview: https://barista-72rjdohbx.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit d5fe757

✅ Preview: https://barista-ll0ozds4k.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 3e08e6e

✅ Preview: https://barista-ldtkdubrs.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit ca55a52

✅ Preview: https://barista-8covauby6.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 83ec1a2

✅ Preview: https://barista-mlhmtw1e1.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit ea7c3f4

✅ Preview: https://barista-c47gaibp3.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer
Copy link
Contributor Author

image

testing with jest and stylelint worked out great now on windows.

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 72f29e1

✅ Preview: https://barista-967q0ck5w.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 8f356a6

✅ Preview: https://barista-bqvu04iez.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit cfcf850

✅ Preview: https://barista-6o9cfioop.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the ci/fix-windows-manifest-error branch 2 times, most recently from 9329ace to 1af5809 Compare September 24, 2020 06:20
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 1af5809

✅ Preview: https://barista-5wezai6ud.vercel.app

This pull request is being automatically deployed with now-deployment

ci(bazel): Fixes an issue where bazel could not create runfiles on wi…
f4b4556 
…ndows.

This issue is due to som legacy runfiles linking where a manifest file was expected where it was not on windows.
@lukasholzer lukasholzer marked this pull request as ready for review September 24, 2020 06:45
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit f4b4556

✅ Preview: https://barista-hbbzdpbwq.vercel.app

This pull request is being automatically deployed with now-deployment

@christian-fischer
Copy link
Contributor

christian-fischer commented Sep 24, 2020 •
edited

just tried bazel run //libs/barista-components/button:test and bazel run //libs/barista-components/button:stylelint and it works fine on my windows machine.

Also any (intentionally added) errors are now nicely visible on the log:

Error: Lint errors found in the listed files:
ÔØî libs\barista-components\button\src\_button-theme.scss ,
 libs\barista-components\button\src\button.scss
L6: Delete "ÔÅÄ" (prettier/prettier)
L5: Expected class selector ".foo" to match specified pattern (selector-class-pattern)
    at C:\tools\bazel_rules\stylelint\run-stylelint.ts:64:11
    at Generator.next (<anonymous>)
    at fulfilled (C:\tmp\46maqhrj\external\npm\node_modules\tslib\tslib.js:111:62)

@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Sep 25, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Sep 25, 2020
@lukasholzer lukasholzer merged commit d6bccff into master Sep 25, 2020
@lukasholzer lukasholzer deleted the ci/fix-windows-manifest-error branch September 25, 2020 05:47
@github-actions
Copy link

The auto cherry picker succeeded.Cherry picked to minor branch 8.x. New head is now 0c28f26
Cherry picked to patch branch 8.0.x. New head is now 88be25b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heartdisease heartdisease heartdisease approved these changes

@ffriedl89 ffriedl89 Awaiting requested review from ffriedl89 ffriedl89 is a code owner

@thomaspink thomaspink Awaiting requested review from thomaspink

@tomheller tomheller Awaiting requested review from tomheller tomheller is a code owner

@SkaillZ SkaillZ Awaiting requested review from SkaillZ

Assignees
No one assigned
Labels
bazel All issues realted to bazel build system pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukasholzer @christian-fischer @heartdisease