Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print all empty octets as empty strings #883

Merged
merged 3 commits into from May 15, 2024
Merged

fix: print all empty octets as empty strings #883

merged 3 commits into from May 15, 2024

Conversation

matteo-cristino
Copy link
Collaborator

  • fix: print all empty octets as empty strings
  • test(zencode): add failing tests with empty octets in the trace

@matteo-cristino
Copy link
Collaborator Author

@jaromil I think I will need your help for this part https://github.com/dyne/Zenroom/pull/883/files#diff-2d5670cdc813fe0e61b94eb79c029066d90b15a37ddffc012283322702c3920dR199, not quite sure of how to do it

@jaromil
Copy link
Member

jaromil commented May 15, 2024

many thanks for this additional test!

@jaromil jaromil merged commit 7c432a6 into master May 15, 2024
26 checks passed
@jaromil jaromil deleted the fix/empty_string branch May 15, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaromil jaromil jaromil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matteo-cristino @jaromil