Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing_tools.dart #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update testing_tools.dart #153

wants to merge 3 commits into from

Conversation

takassh
Copy link

@takassh takassh commented Apr 12, 2022

Hi, thank you for publishing this package! It is so useful for us!

I found a subtle need.
pumpDeviceBuilder does not have textScaleSize argument, so I added it!

Add textScaleSize
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #153 (c687e26) into master (b8cf574) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          12       12           
  Lines         364      364           
=======================================
  Hits          363      363           
  Misses          1        1           
Impacted Files Coverage Δ
packages/golden_toolkit/lib/src/testing_tools.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8cf574...c687e26. Read the comment docs.

@coreysprague
Copy link
Contributor

@takassh thanks for the contribution! Would you mind adding a test to demonstrate the behavior?

@takassh
Copy link
Author

takassh commented Apr 15, 2022

@coreysprague
np!
I added a test
it means you can easily compare text scale among other devices

Copy link
Contributor

@coreysprague coreysprague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll get this out in a new release shortly

@takassh
Copy link
Author

takassh commented Apr 26, 2022

@coreysprague
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants