fix semantics autoheight with scroll views #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manu-sncf
force-pushed
the
fix-semantics-autoheight
branch
from
8670787
to
967e903
Compare
|
Is it possible to use CustomPump? customPump? param instead |
Hey ! The customPump is triggered before the final size computation of the screen. Although, SemanticDebugger needs this final size to be displayed correctly and thus, customPump may not be the solution. |
|
Could this be reviewed/merged ? |
|
any news about this PR ?! |
|
Could we have a status for this ? This feature would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SemanticsDebuggeris used with a Scrollable, the semantics boxes are partially displayed :The golden should be like this :
The fix only add a few pumps on
screenMatchesGoldenwhen it detect aSemanticsDebugger(5 pumps max if frame are scheduled).The
autoHeightExtraPumpsallows to add otherFinderwith their number of extra pumps necessary.Extra pump will be executed if one of the finder is valid and keep the max number of the map.