Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add variant in test #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kiruel
Copy link

@Kiruel Kiruel commented Dec 7, 2022

Able to pass variant argument to testGoldens()

@mZadorskii
Copy link
Contributor

mZadorskii commented Dec 7, 2022

@Kiruel thanks for contribution and dependency bumps!
I've never noticed those variants APIs, used to loops like:
image

Meanwhile.. we were planning to do a global re-work of scenarios and GoldenBuilder APIs (breaking changes)

Can you please add a test with a golden that verifies that text style and color are properly applied?

@Kiruel
Copy link
Author

Kiruel commented Dec 9, 2022

Sorry I merge this one #164 with this PR. I close the another one and work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants