Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache mount depending on inactive args #1000

Merged
merged 1 commit into from
May 21, 2021
Merged

Fix cache mount depending on inactive args #1000

merged 1 commit into from
May 21, 2021

Conversation

vladaionescu
Copy link
Member

  • Cache mount ID now depends on a target input hash which does not include inactive variables
  • Cache mount base image is now simply scratch (previously it was an empty host dir, but this seems unnecessary now)

Fixes #996

@vladaionescu vladaionescu requested review from dchw and alexcb May 21, 2021 21:20
@vladaionescu vladaionescu mentioned this pull request May 21, 2021
Closed
@vladaionescu vladaionescu enabled auto-merge (squash) May 21, 2021 21:23
@vladaionescu vladaionescu merged commit 4c5dab1 into main May 21, 2021
@vladaionescu vladaionescu deleted the vlad/fix-cache-mount-arg branch May 21, 2021 21:37
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcb alexcb alexcb approved these changes

@dchw dchw Awaiting requested review from dchw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build arguments affect cache reuse of parent target if cache mounts are used there
2 participants
@vladaionescu @alexcb