Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install bash completion file on debian #1019

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented May 28, 2021

I tried to make use of dh $@ --with bash-completion in a rules file however I just couldn't get auto-completion to persist when I logged out and back in. Ultimately I figured we could stick with the approach that homebrew uses to have the earthly binary output the auto-completion contents.

Signed-off-by: Alex Couture-Beil alex@earthly.dev

@alexcb alexcb force-pushed the post-install-script branch 4 times, most recently from 8184450 to b021592 Compare June 11, 2021 22:14
@alexcb alexcb marked this pull request as ready for review June 11, 2021 22:17
@alexcb alexcb requested review from dchw and vladaionescu June 11, 2021 22:17
Copy link
Member

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🆒

echo "docker was not found; skipping earthly bootstrap"
exit
fi
if ! docker info 2>/dev/null >/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb merged commit 9ae2b44 into main Jun 14, 2021
@alexcb alexcb deleted the post-install-script branch June 14, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants