-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bless Earthly Docker Image #1050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchw
commented
Jun 8, 2021
…This usually happens when `--network=host`
vladaionescu
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, hence approve
…word for logging in to secrets, and do not require privileged mode if using an external buildkit.
alexcb
reviewed
Jun 8, 2021
alexcb
approved these changes
Jun 8, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp entrypoint to make it more user-friendly and button it down more. Dogfoods it within our own unit testing. Docs coming once merged so I don't have to keep those up to date too with any changes here.
Sample invocation 1:
docker run --privileged -t -e NO_DOCKER=1 -v $(pwd):/src earthly/earthly:v0.5.15 +for-linux
-t
lets Earthly detect that there is a TTY. Better than usingFORCE_COLOR
, when possible.-e NO_DOCKER=1
Skips the Docker check. Useful for when you don't need to save images, etc.-v $(pwd):/src
is mounting the current dir into the conventional spot for invoking earthly.Sample invocation 2:
docker run --privileged -t -v ~/.docker:/root/.docker -v /var/run/docker.sock:/var/run/docker.sock -e DOCKER_HOST="unix:///var/run/docker.sock" -v $(pwd):/src earthly/earthly:v0.5.15 +for-linux
DOCKER_HOST
variable. If the daemon is remote or accessible otherwise, the socket mount would not be needed. Also note mounting.docker
; this preserves any credentials. Should we support adocker login
here?