Allow using Podman to develop Earthly #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes partial refactor of URL generation.
alexcb
reviewed
Feb 16, 2022
alexcb
reviewed
Feb 16, 2022
alexcb
reviewed
Feb 16, 2022
alexcb
reviewed
Feb 16, 2022
alexcb
approved these changes
Feb 16, 2022
Handled. |
alexcb
reviewed
Feb 16, 2022
This reverts commit 2f9c9ee.
|
@alexcb I think I cleaned up the test failure reasons. The refactor hid a very sneaky bug; would love your re-review to make sure its still ok to merge. |
dchw
commented
Feb 18, 2022
| fe.urls, err = fe.setupAndValidateAddresses(FrontendStub, cfg) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to calculate buildkit URLs") | ||
| } |
There was a problem hiding this comment.
This was the source of the bug. We used to calculate URLs after choosing a frontend; but by choosing the stub, we would end up skipping the calculations instead during our unit tests. The solution was to also let the stub calculate URLs; so the remote buildkit would end up being chosen.
There was a problem hiding this comment.
Ohhhh buddy did this take a while to figure out.
alexcb
reviewed
Feb 22, 2022
util/containerutil/docker.go
Outdated
| all := []string{binary} | ||
| all = append(all, args...) | ||
|
|
||
| return fmt.Sprintf("cat %s | %s", filename, strings.Join(all, " ")) |
There was a problem hiding this comment.
Suggested change
| return fmt.Sprintf("cat %s | %s", filename, strings.Join(all, " ")) | |
| return fmt.Sprintf("cat %s | %s", shellescape.QuoteCommand(filename), strings.Join(all, " ")) |
alexcb
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix a couple sore points when using Podman to develop Earthly itself:
registries.conf.WITH DOCKER --loadin aLOCALLYtarget.