Try to fallback to CNI gateway when regular address fails. #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
reviewed
Feb 23, 2022
alexcb
approved these changes
Feb 23, 2022
Co-authored-by: Alex Couture-Beil <alex@earthly.dev>
vladaionescu
approved these changes
Feb 23, 2022
vladaionescu
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CNI spec, our
host-localipam module will always put the gateway at.1inside our subnet. If the derived address from the config fails to connect, fallback and try the internal CNI gateway. Should improve compatibility when the container does not have an IP, such as rootless configurations.Fixes #1573.