New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EARTHLY_CI arg #2398
Merged
Merged
Add EARTHLY_CI arg #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an `EARTHLY_CI` builtin arg which is set to `true` when earthly is run with the `--ci` flag.
alexcb
reviewed
Nov 14, 2022
alexcb
reviewed
Nov 14, 2022
alexcb
reviewed
Nov 14, 2022
alexcb
reviewed
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, looks good -- just left a couple minor requests.
* main: (30 commits) Support NETRC environmental var (earthly#2426) Add installation name to the changelog (earthly#2427) Add some basic buffering to conslogging (earthly#2425) switch satellite back to core-test (earthly#2424) Don't expire when JWT set externally (earthly#2418) Add all the non-buildkit output to logstream too (earthly#2423) More fields on satellite ls and inspect (earthly#2412) Fix linebreak (earthly#2421) Fix logstream closing sequence (earthly#2422) fix singlequote parsing for --shell-out-anywhere (earthly#2419) Update earthfile-syntax-highlighting release instructions (earthly#2420) Changes in vscode-syntax-highlighting-v0.0.12 (earthly#2407) fix incorrect session ID passed to llb.SessionID (earthly#2413) Allow passing a JWT to Earthly for accessing cloud features (earthly#2414) Fix `time.Now().UnixNano()` stripping away the nanos (earthly#2415) Update CHANGELOG.md (earthly#2393) docs: Satellite sleep behaviour (earthly#2380) Bump nokogiri from 1.12.5 to 1.13.9 in /examples/ruby-on-rails (earthly#2411) Bump nokogiri from 1.11.0 to 1.12.5 in /examples/ruby-on-rails (earthly#2295) run tests on docs (earthly#2410) ...
alexcb
force-pushed
the
issue-2261-earthly-ci
branch
from
November 21, 2022 19:04
ea17e8e
to
8944e35
Compare
Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb
force-pushed
the
issue-2261-earthly-ci
branch
from
November 21, 2022 19:05
8944e35
to
c24ed22
Compare
alexcb
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2261.
This adds an
EARTHLY_CI
builtin arg which is set totrue
when earthly is run with the--ci
flag.