Support NETRC environmental var #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladaionescu
approved these changes
Nov 18, 2022
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ All notable changes to [Earthly](https://github.com/earthly/earthly) will be doc | |||
| ### Changed | |||
|
|
|||
| - Updated buildkit to include changes up to [a5263dd0f990a3fe17b67e0002b76bfd1f5b433d](https://github.com/moby/buildkit/commit/a5263dd0f990a3fe17b67e0002b76bfd1f5b433d), which includes a change to speed-up buildkit startup time. | |||
| - Added support for a custom `.netrc` file path using the standard `NETRC` environmental variable. [#2426](https://github.com/earthly/earthly/pull/2426) | |||
There was a problem hiding this comment.
This should go under ### Added actually.
|
FYI - I fixed a merge conflict --> Merge branch 'main' into mh/netrc-env |
miles170
added a commit
to miles170/earthly
that referenced
this pull request
Nov 19, 2022
* main: (30 commits) Support NETRC environmental var (earthly#2426) Add installation name to the changelog (earthly#2427) Add some basic buffering to conslogging (earthly#2425) switch satellite back to core-test (earthly#2424) Don't expire when JWT set externally (earthly#2418) Add all the non-buildkit output to logstream too (earthly#2423) More fields on satellite ls and inspect (earthly#2412) Fix linebreak (earthly#2421) Fix logstream closing sequence (earthly#2422) fix singlequote parsing for --shell-out-anywhere (earthly#2419) Update earthfile-syntax-highlighting release instructions (earthly#2420) Changes in vscode-syntax-highlighting-v0.0.12 (earthly#2407) fix incorrect session ID passed to llb.SessionID (earthly#2413) Allow passing a JWT to Earthly for accessing cloud features (earthly#2414) Fix `time.Now().UnixNano()` stripping away the nanos (earthly#2415) Update CHANGELOG.md (earthly#2393) docs: Satellite sleep behaviour (earthly#2380) Bump nokogiri from 1.12.5 to 1.13.9 in /examples/ruby-on-rails (earthly#2411) Bump nokogiri from 1.11.0 to 1.12.5 in /examples/ruby-on-rails (earthly#2295) run tests on docs (earthly#2410) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a custom
.netrcfile path using the (apparently) standardNETRCenv. https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-file.html