dont attempt secrets lookup when org or project not set #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where using `VERSION --use-project-secrets 0.6` causes secrets to be lookedup in the cloud with an empty org or project, which returns an unauthorized error rather than the expected `unable to lookup secret SECRET3: not found` error message (which causes the `+secrets-test` test to fail). Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
|
I'm torn between expanding our integration tests to catch this -- it's a growing issue where introducing feature flags cause a combinatorics-expansion of tests required to maintain full coverage. When #2237 is released, we'll be updating this to be |
vladaionescu
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where using
VERSION --use-project-secrets 0.6causes secrets to be lookedup in the cloud with an empty org or project, which returns an unauthorized error rather than the expectedunable to lookup secret SECRET3: not founderror message (which causes the+secrets-testtest to fail).Signed-off-by: Alex Couture-Beil alex@earthly.dev