Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix should_fail arg #4055

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

tests: fix should_fail arg #4055

wants to merge 2 commits into from

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented Apr 23, 2024

should-fail is not an ARG, but should_fail is.

@alexcb
tests: fix should_fail arg
a4bee57 
`should-fail` is not an ARG, but `should_fail` is.

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb
Copy link
Collaborator Author

alexcb commented Apr 23, 2024 •
edited

@idodod I noticed that --should-fail was introduced in e7e02b4

But that commit also introduced a target called test-fails which doesn't seem to be referenced anywhere.

My gut is telling me we should update the referenced target name too?

@alexcb
Copy link
Collaborator Author

alexcb commented Apr 23, 2024

My gut is telling me we should update the referenced target name too?

just added this; let's see if this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
core
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexcb